[PATCH v9 0/2] Adds PMU and S2R support for exynos5420

Vikas Sajjan vikas.sajjan at samsung.com
Wed Oct 8 04:51:28 PDT 2014


Hi Javier,

On Wed, Oct 8, 2014 at 3:42 PM, Javier Martinez Canillas
<javier at dowhile0.org> wrote:
> Hello Vikas,
>
> On Wed, Oct 8, 2014 at 11:26 AM, Vikas Sajjan <vikas.sajjan at samsung.com> wrote:
>>>>
>>>> Can you please pick this series.
>>>>
>>> Yes, sure I will queue this series after -rc1 release.
>>
>
> Not related to your series but did you figure out why the
> aclk200_disp1 and aclk300_disp1 clocks are left unused?
>

As mentioned earlier, I recently noticed that these clocks are
preventing system from suspending.
These clocks are used by the in-flight DRM display driver and once it
is merged the display driver will be handling the clock during boot-up
and suspend/resume.

In our internal tree (3.17-rc5 based) where we have DRM display driver
enabled, we do not see any issues and do not need to add the
CLK_IGNORE_UNUSED flag.

> I'm carrying your patch to flag those clocks as CLK_IGNORE_UNUSED to
> prevent being disabled by the CCF. And while that allows me to test,
> I'm afraid that it may not be the proper solution since it could just
> be hiding the real cause of the issue.

Till the DRM display driver gets merged, we can continue to use this
for testing purposes.

>
> Of course this should not block your series from been merged but I
> just wondered if you found the cause since it would be nice to have
> s2r properly working on exynos5420.


>
>> Thank you.
>>
>>>
>>> Thanks,
>>> Kukjin
>>>
>
> best regards,
> Javier
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list