[PATCH] imx: thermal: imx_get_temp might be called before the sensor clock ist prepared

Fabio Estevam festevam at gmail.com
Tue Oct 7 12:42:15 PDT 2014

Hi Heiner,

On Tue, Oct 7, 2014 at 4:36 PM, Heiner Kallweit <heiner.kallweit at web.de> wrote:
> Thanks for the hint, Philipp.
> After thinking a little bit more about it I'm not sure about one thing:
> If we can't get the clock or fail to enable it: Currently the code just throws
> a warning and proceeds with trying to register the thermal device.
> Does this make sense or shall we bail out instead (like in case of other error conditions
> in imx_thermal_probe)? I'd tend to bail out ..

Agree with you. We should do a 'return ret' if clk_prepare_enable()
fails. Thanks

More information about the linux-arm-kernel mailing list