[PATCH 2/2] net: spider_net: avoid using signed char for bitops

Arnd Bergmann arnd at arndb.de
Fri Oct 3 08:15:05 PDT 2014


On Friday 03 October 2014 17:01:56 Antoine Tenart wrote:
> Signedness bugs may occur when using signed char for bitops,
> depending on if the highest bit is ever used.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart at free-electrons.com>
> 

It's probably worth mentioning here that this cannot happen in this
driver because it's only used in one powerpc-specific chip, and 'char'
is always 'unsigned' on powerpc.

	Arnd



More information about the linux-arm-kernel mailing list