[PATCH v2 2/4] ARM: exynos: Ensure PM domains are powered at initialization
Ulf Hansson
ulf.hansson at linaro.org
Wed Oct 1 07:41:32 PDT 2014
At ->probe() it's common practice for drivers/subsystems to bring their
devices to full power and without depending on CONFIG_PM_RUNTIME.
We could also expect that drivers/subsystems requires their device's
corresponding PM domains to be powered, to successfully complete a
->probe() sequence.
Align to the behavior above, by ensuring all PM domains are powered
prior initialization of a generic PM domain.
Do note, since the generic PM domain will try to power off unused PM
domains at late_init, there should be no increased power consumption
over time, but potentially during boot.
Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
---
arch/arm/mach-exynos/pm_domains.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
index 20f2671..58e18e9 100644
--- a/arch/arm/mach-exynos/pm_domains.c
+++ b/arch/arm/mach-exynos/pm_domains.c
@@ -112,7 +112,7 @@ static __init int exynos4_pm_init_power_domain(void)
for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") {
struct exynos_pm_domain *pd;
- int on, i;
+ int i;
struct device *dev;
pdev = of_find_device_by_node(np);
@@ -155,9 +155,10 @@ static __init int exynos4_pm_init_power_domain(void)
clk_put(pd->oscclk);
no_clk:
- on = __raw_readl(pd->base + 0x4) & INT_LOCAL_PWR_EN;
+ if (!(__raw_readl(pd->base + 0x4) & INT_LOCAL_PWR_EN))
+ exynos_pd_power_on(&pd->pd);
- pm_genpd_init(&pd->pd, NULL, !on);
+ pm_genpd_init(&pd->pd, NULL, false);
of_genpd_add_provider_simple(np, &pd->pd);
}
--
1.9.1
More information about the linux-arm-kernel
mailing list