[PATCH v4 2/2] iommu/arm-smmu: add support for iova_to_phys through ATS1PR

Arnd Bergmann arnd at arndb.de
Wed Oct 1 01:27:27 PDT 2014


On Tuesday 30 September 2014 18:28:13 Mitchel Humpherys wrote:
> +       if (readl_poll_timeout_atomic(cb_base + ARM_SMMU_CB_ATSR, tmp,
> +                               !(tmp & ATSR_ACTIVE), 50, 100)) {
> 

This looks really bad.

You are doing up to 50 100us delays, each of which can be much longer,
so you can do up to 10ms total delay with interrupts disabled.

Don't do that.

	Arnd



More information about the linux-arm-kernel mailing list