[PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile

Mark Rutland mark.rutland at arm.com
Thu Nov 27 05:43:09 PST 2014


On Thu, Nov 27, 2014 at 12:12:15PM +0000, Catalin Marinas wrote:
> On Thu, Nov 27, 2014 at 11:50:43AM +0000, Mark Rutland wrote:
> > On Tue, Nov 25, 2014 at 12:16:56PM +0000, Chunyan Zhang wrote:
> > > +
> > > +       timer {
> > > +               compatible = "arm,armv8-timer";
> > > +               interrupts = <1 13 0xff01>,
> > > +                            <1 14 0xff01>,
> > > +                            <1 11 0xff01>,
> > > +                            <1 10 0xff01>;
> > > +               clock-frequency = <26000000>;
> > 
> > Please remove the clock-frequency property. Your FW should initialise
> > CNTFRQ_EL0 on all CPUs (certainly PSCI 0.2 requires that you do this).
> 
> Since this comes up regularly, I think we need a dev_warn() in the arch
> timer driver when CONFIG_ARM64.

I'll ack such a patch ;)

Mark.



More information about the linux-arm-kernel mailing list