[PATCH] ARM: orion: convert the irq_reg_{readl, writel} calls to the new API

Arnd Bergmann arnd at arndb.de
Wed Nov 26 00:58:34 PST 2014


On Tuesday 25 November 2014 21:38:53 Jason Cooper wrote:
> On Tue, Nov 25, 2014 at 09:59:11PM +0100, Arnd Bergmann wrote:
> > On Tuesday 25 November 2014 12:24:16 Olof Johansson wrote:
> > > On Tue, Nov 25, 2014 at 7:19 AM, Gregory CLEMENT
> > > <gregory.clement at free-electrons.com> wrote:
> > > > The commit "genirq: Generic chip: Change irq_reg_{readl,writel}
> > > > arguments" modified the API. In the same tome the
> > > > arch/arm/plat-orion/gpio.c file received a fix with the use of the old
> > > > API: "ARM: orion: Fix for certain sequence of request_irq can cause
> > > > irq storm". This commit fixes the use of the API.
> > > >
> > > > Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> > > > ---
> > > > Hi Jason,
> > > >
> > > > This patch fix a build error in linux-next:
> > > >
> > > > arch/arm/plat-orion/gpio.c:509:12: error: too few arguments to function 'irq_reg_readl'
> > > > arch/arm/plat-orion/gpio.c:511:2: error: too few arguments to function 'irq_reg_writel'
> > > > arch/arm/plat-orion/gpio.c:523:12: error: too few arguments to function 'irq_reg_readl'
> > > > arch/arm/plat-orion/gpio.c:525:2: error: too few arguments to function 'irq_reg_writel'
> > > >
> > > > But if we want to apply it on the mvebu branch we need to add a
> > > > dependecy to "332fd7c4fef5 genirq: Generic chip: Change
> > > > irq_reg_{readl,writel} arguments"
> > > 
> > > Please take this through the same repo as the change in the prototype:
> > > 
> > > Acked-by: Olof Johansson <olof at lixom.net>
> > > 
> > 
> > As mentioned before, the problem here is that the prototype gets changed
> > in the irqchip repo, while the gpio driver only starts using this interface
> > in the mvebu repo. Both trees are owned by Jason, so he should be able
> > to find a solution though.
> 
> I made myself promise not rebase mvebu/fixes.  :-)

Ah, I hadn't realized that the gpio change is already in 3.18-rc, that actually
simplifies it.

	Arnd



More information about the linux-arm-kernel mailing list