[PATCH 1/2] ARM: shmobile: sh73a0 legacy/reference: Add missing INTCA0 clock for irqpin module

[Geert Uytterhoeven]

On Tue, Nov 25, 2014 at 10:31 AM, Geert Uytterhoeven
<geert at linux-m68k.org> wrote:
> On Tue, Nov 25, 2014 at 3:44 AM, Simon Horman <horms at verge.net.au> wrote:
>> On Wed, Nov 19, 2014 at 04:26:59PM +0100, Geert Uytterhoeven wrote:
>>> This clock drives the irqpin controller modules.
>>> Before, it was assumed enabled by the bootloader or reset state.
>>> By making it available to the driver, we make sure it gets enabled when
>>> needed, and allow it to be managed by system or runtime PM.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
>>
>> Hi Geert,
>>
>> should this be considered a fix?
>
> In some sense this is a fix. But I don't think anyone is suffering from it.
> Just poor guys like me who disable all MSTP clocks in early boot code,
> to find more missing clock declarations and more drivers that don't manage
> their clocks ;-)
>
>> If so could you cook up some text describing which patch introduced
>> this problem in which kernel version.
>
> I guess that would be:
>
> commit 341eb5465f67437ad37ef2f6302b581beda4614a
> Author: Magnus Damm <damm at opensource.se>
> Date:   Tue Feb 26 12:01:09 2013 +0900
>
>     ARM: shmobile: INTC External IRQ pin driver on sh73a0
>
> But I don't think it's worth adding that, or do you plan to backport
> this to LTSI?

Seeing the similar fix for r8a7740 has landed in backports, I now assume
you will ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds