[PATCH v5 3/6] arm64: Add framework for legacy instruction emulation

[Punit Agrawal]

Hi Greg,

Greg Hackmann <ghackmann at google.com> writes:

> If it's not too late to chime in, I ran across one issue testing this
> patchset:

Sure. Thanks for taking the patches for a spin.

>
> On Tue, Nov 18, 2014 at 3:41 AM, Punit Agrawal <punit.agrawal at arm.com> wrote:
>> +       ret = update_insn_emulation_mode(insn, prev_mode);
>> +       if (!ret) {
>> +               /* Mode change failed, revert to previous mode. */
>> +               insn->current_mode = prev_mode;
>> +               update_insn_emulation_mode(insn, INSN_UNDEF);
>> +       }
>
> update_insn_emulation_mode() returns 0 on success, so the condition
> needs to be "if (ret)".  Otherwise writes to the sysctl file are
> immediately rolled back.

Dang! Missed this in the testing before posting. I'll co-ordinate with
Will to get the fix into next.

>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel