[PATCH 1/2] ARM: shmobile: sh73a0 legacy/reference: Add missing INTCA0 clock for irqpin module

Simon Horman horms at verge.net.au
Mon Nov 24 18:44:06 PST 2014


On Wed, Nov 19, 2014 at 04:26:59PM +0100, Geert Uytterhoeven wrote:
> This clock drives the irqpin controller modules.
> Before, it was assumed enabled by the bootloader or reset state.
> By making it available to the driver, we make sure it gets enabled when
> needed, and allow it to be managed by system or runtime PM.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

Hi Geert,

should this be considered a fix?

If so could you cook up some text describing which patch introduced
this problem in which kernel version.

> ---
>  arch/arm/mach-shmobile/clock-sh73a0.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/mach-shmobile/clock-sh73a0.c b/arch/arm/mach-shmobile/clock-sh73a0.c
> index 6b4c1f313cc987c1..3855fb024fdbb1ca 100644
> --- a/arch/arm/mach-shmobile/clock-sh73a0.c
> +++ b/arch/arm/mach-shmobile/clock-sh73a0.c
> @@ -553,6 +553,7 @@ enum { MSTP001,
>  	MSTP314, MSTP313, MSTP312, MSTP311,
>  	MSTP304, MSTP303, MSTP302, MSTP301, MSTP300,
>  	MSTP411, MSTP410, MSTP403,
> +	MSTP508,
>  	MSTP_NR };
>  
>  #define MSTP(_parent, _reg, _bit, _flags) \
> @@ -597,6 +598,7 @@ static struct clk mstp_clks[MSTP_NR] = {
>  	[MSTP411] = MSTP(&div4_clks[DIV4_HP], SMSTPCR4, 11, 0), /* IIC3 */
>  	[MSTP410] = MSTP(&div4_clks[DIV4_HP], SMSTPCR4, 10, 0), /* IIC4 */
>  	[MSTP403] = MSTP(&r_clk, SMSTPCR4, 3, 0), /* KEYSC */
> +	[MSTP508] = MSTP(&div4_clks[DIV4_HP], SMSTPCR5, 8, 0), /* INTCA0 */
>  };
>  
>  /* The lookups structure below includes duplicate entries for some clocks
> @@ -677,6 +679,14 @@ static struct clk_lookup lookups[] = {
>  	CLKDEV_DEV_ID("i2c-sh_mobile.4", &mstp_clks[MSTP410]), /* I2C4 */
>  	CLKDEV_DEV_ID("e6828000.i2c", &mstp_clks[MSTP410]), /* I2C4 */
>  	CLKDEV_DEV_ID("sh_keysc.0", &mstp_clks[MSTP403]), /* KEYSC */
> +	CLKDEV_DEV_ID("renesas_intc_irqpin.0",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("e6900000.irqpin",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("renesas_intc_irqpin.1",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("e6900004.irqpin",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("renesas_intc_irqpin.2",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("e6900008.irqpin",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("renesas_intc_irqpin.3",	&mstp_clks[MSTP508]), /* INTCA0 */
> +	CLKDEV_DEV_ID("e690000c.irqpin",	&mstp_clks[MSTP508]), /* INTCA0 */
>  
>  	/* ICK */
>  	CLKDEV_ICK_ID("dsit_clk", "sh-mipi-dsi.0", &div6_clks[DIV6_DSIT]),
> -- 
> 1.9.1
> 



More information about the linux-arm-kernel mailing list