[PATCH] ARM: shmobile: r8a7790 CCI configuration
Arnd Bergmann
arnd at arndb.de
Fri Nov 21 02:57:28 PST 2014
On Friday 21 November 2014 13:09:46 Simon Horman wrote:
> + writel_relaxed(readl_relaxed(p + CCI_SLAVE4 + CCI_SNOOP) | 0x3,
> + p + CCI_SLAVE4 + CCI_SNOOP); /* ca7 */
> + while (__raw_readl(p + CCI_STATUS));
> + /* wait for pending bit low */
>
Why are you using __raw_readl for the last access? I would make that
readl_relaxed() like the other ones for consistency.
Also, a better way to express waiting for the register read is to
put the ';' on the next line, or add a cpu_relax() statement:
while (readl_relaxed(p + CCI_STATUS))
cpu_relax();
Arnd
More information about the linux-arm-kernel
mailing list