[PATCH v9 2/9] qcom: spm: Add Subsystem Power Manager driver
Bjorn Andersson
bjorn at kryo.se
Tue Nov 18 11:39:47 PST 2014
On Mon, Nov 17, 2014 at 1:32 PM, Daniel Lezcano
<daniel.lezcano at linaro.org> wrote:
> On 10/25/2014 01:40 AM, Lina Iyer wrote:
>
> Hi Lina,
>
> [ ... ]
>
>> +static inline void spm_register_write(struct spm_driver_data *drv,
>> + enum spm_reg reg, u32 val)
>> +{
>> + if (drv->reg_data->reg_offset[reg])
>> + writel_relaxed(val, drv->reg_base +
>> + drv->reg_data->reg_offset[reg]);
>
>
> Why not use writel and don't use 'wmb' below ?
>
Hi Daniel,
writel() provides ordering before the write, not after. Please have a
look at the definition.
Regards,
Bjorn
More information about the linux-arm-kernel
mailing list