[PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Nov 17 07:56:17 PST 2014


On Mon, Nov 17, 2014 at 07:26:29PM +0530, Krishna Mohan Dani wrote:
> Fixes the following compilation warning:
> Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used.
> 
> Signed-off-by: Claude Youn <claude.youn at gmail.com>
> Signed-off-by: Krishna Mohan Dani <krishna.md at samsung.com>
> ---
>  sound/soc/codecs/rt5631.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
> index 3b7d5e4..9425545 100644
> --- a/sound/soc/codecs/rt5631.c
> +++ b/sound/soc/codecs/rt5631.c
> @@ -1691,12 +1691,14 @@ static const struct i2c_device_id rt5631_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5631_i2c_id);
>  
> +#ifdef CONFIG_OF
>  static struct of_device_id rt5631_i2c_dt_ids[] = {
>  	{ .compatible = "realtek,rt5631"},
>  	{ .compatible = "realtek,alc5631"},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, rt5631_i2c_dt_ids);
> +#endif

An (IMHO nicer) alternative is:

-static struct of_device_id rt5631_i2c_dt_ids[] = {
+static struct of_device_id rt5631_i2c_dt_ids[] __maybe_unused = {

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list