[PATCH] gpio: mxs: implement get_direction callback

Janusz Użycki j.uzycki at elproma.com.pl
Mon Nov 17 06:29:30 PST 2014


Hi Richard,

W dniu 2014-11-17 o 11:05, Richard Genoud pisze:
> 2014-11-17 10:59 GMT+01:00 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
>
> well, in this case, request_irq() will fail and all the previously
> requested irqs will be freed:
>      /*
>       * If something went wrong, rollback.
>       */
>      while (err && (--i >= 0))
>          if (irq[i] >= 0)
>              free_irq(irq[i], port);

I hesitate if use the rollback or just call mctrl_gpio_free_irqs().
Let's note that "i" is enum and the loop ends on i < 0.

best regards
Janusz




More information about the linux-arm-kernel mailing list