Re: [PATCH] gpio: mxs: implement get_direction callback

[Alexander Shiyan]

Mon, 17 Nov 2014 10:59:09 +0100 от Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Hello Richard,
> 
> > >>>> So finally the prototypes would be:
> > >>>> int mctrl_gpio_request_irqs(struct mctrl_gpios*, struct
> > >>>> uart_port*, irqhandler_t);
> > >>>> void mctrl_gpio_free_irqs(struct mctrl_gpios*);
> > >>
> > >> I think:
> > >>
> > >>         struct mctrl_gpios {
> > >>                 struct uart_port *port;
> > >>                 struct {
> > >>                         gpio_desc *gpio;
> > >>                         unsigned int irq;
> > I think it's just "int irq;" there
> irqs are unsigned. Some functions returning an irq use "int", but
> depending on who you ask this only for error reporting or a relict.
> Use 0 for invalid/unused in mctrl_gpio*.

afaik, IRQ 0 is valid irq number.

---