[PATCH V2 1/7] arm64: dts: Add APM X-Gene USB DTS node

Feng Kan fkan at apm.com
Fri Nov 14 11:17:38 PST 2014


On Fri, Nov 14, 2014 at 7:04 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 13 November 2014 16:19:55 Feng Kan wrote:
>>
>> +               usb0: dwusb at 19000000 {
>> +                       status = "disabled";
>> +                       compatible = "xhci-platform";
>> +                       reg =  <0x0 0x19000000 0x0 0x100000>;
>> +                       interrupts = <0x0 0x89 0x4>;
>> +                       dma-coherent;
>> +               };
>> +
>> +               usb1: dwusb at 19800000 {
>> +                       status = "disabled";
>> +                       compatible = "xhci-platform";
>> +                       reg =  <0x0 0x19800000 0x0 0x100000>;
>> +                       interrupts = <0x0 0x8a 0x4>;
>> +                       dma-coherent;
>> +               };
>>
>
> Call the nodes 'usb', not 'dwusb'.
This was a deliberate change on our part to make sure backward
compatibility with a older bootloader.

> Should these be 'status="disabled"', or
> do you expect every machine to have both connected?
Not all platform has both enabled at this point. Not enabling them
would allow us to save some power
if the IP is not used.
>
>         Arnd



More information about the linux-arm-kernel mailing list