[PATCH] efi: Fix free_end build warning

Will Deacon will.deacon at arm.com
Fri Nov 14 02:22:55 PST 2014


[Adding original authors]

On Wed, Nov 12, 2014 at 08:27:30PM +0000, Geoff Levand wrote:
> Initialize the free_end variable to zero.  Fixes build warnings
> like these:
> 
>   arch/arm64/kernel/efi.c: warning: ‘free_end’ may be used uninitialized in this function
> 
> Signed-off-by: Geoff Levand <geoff at infradead.org>
> ---
> Got this with the latest arm64/for-next/core branch.  Please consider.
> 
> -Geoff 
> 
>  arch/arm64/kernel/efi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> index 4f39a18..83fc53c 100644
> --- a/arch/arm64/kernel/efi.c
> +++ b/arch/arm64/kernel/efi.c
> @@ -239,6 +239,7 @@ static void __init free_boot_services(void)
>  	 * want to keep for UEFI.
>  	 */
>  
> +	free_end = 0;
>  	keep_end = 0;
>  	free_start = 0;

Whilst I can't see how free_end gets used uninitialized in this function,
the code is really hard to read and I'd like to get an Ack from one of the
people on CC before merging this, just in case GCC is actually telling us
something useful for a change.

Will



More information about the linux-arm-kernel mailing list