[PATCH v2 06/11] memory: atmel-ebi: add DT bindings documentation
boris.brezillon at free-electrons.com
Fri Nov 7 07:49:40 PST 2014
On Fri, 7 Nov 2014 09:21:39 -0600
Rob Herring <robherring2 at gmail.com> wrote:
> On Wed, Nov 5, 2014 at 10:01 AM, Boris Brezillon
> <boris.brezillon at free-electrons.com> wrote:
> > Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Perhaps some commit msg?
Yes, I was just lazy and though this series would make another round
I'll add a commit log to all my commits...
> While this binding seems mostly okay to me, this is the 2nd memory
> controller binding I've looked at in the last day . There are
> probably some others already as well. This makes me think we need a
> generic binding here. At least the node structure and how we define
> chip selects should be common.
Any suggestion ?
BTW, I don't use any specific property to define the chip select
associated to a device, because it's already encoded in the reg
TI AEMIF binding define an ti,cs-chipselect property, is there any
reason for doing that ?
Moreover, IMHO it would even make sense to have some sort of
framework/helper functions for those kind of interfaces to external
memories, but this is another story :-).
> While I like timing information in time units over magic register
> values in the Tegra binding, the reality is converting timing info to
> register values is generally very hard to get both correct and
> optimal. In the end, you probably need to hand tweak the register
> settings anyway. So I'm hesitant to say it must be done 1 way here.
Well, I'm not a big fan of timings expressed in clock cycles, cause
this implies changing your DT when you tweak your master/bus clk.
Expressing those timings in nano or pico seconds let the driver figure
out what's the best value according to the current source clk rate.
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
More information about the linux-arm-kernel