[PATCHv3 2/5] arm64: Add AArch32 instruction set condition code checks

[Catalin Marinas]

On Wed, Oct 29, 2014 at 03:21:48PM +0000, Russell King - ARM Linux wrote:
> On Mon, Oct 27, 2014 at 06:40:04PM +0000, Punit Agrawal wrote:
> >  arm64-obj-$(CONFIG_COMPAT)		+= sys32.o kuser32.o signal32.o 	\
> > -					   sys_compat.o
> > +					   sys_compat.o 			\
> > +					   $(addprefix ../../arm/kernel/,	\
> > +						opcodes.o)
> 
> This is not particularly nice.

Not that bad, you can look at it as a decoding library.

> While it means that this file gets built on both arm64 and arm, it
> means that it routinely won't get tested on arm64 when changes to it
> happen.

Low risk, it's a small file unlikely to change in the future.

Anyway, since you mention testing, I wonder how regularly SWP emulation
gets tested on arm32 (and in future arm64). If Punit has some tests
already, it may be good to add them somewhere like
tools/testing/selftests/arm/ (probably separately from this series).

-- 
Catalin