[PATCHv3 1/5] arm64: Add support for hooks to handle undefined instructions

Catalin Marinas catalin.marinas at arm.com
Wed Nov 5 03:27:50 PST 2014


On Mon, Oct 27, 2014 at 06:40:02PM +0000, Punit Agrawal wrote:
> --- a/arch/arm64/include/asm/insn.h
> +++ b/arch/arm64/include/asm/insn.h
> @@ -354,6 +354,8 @@ bool aarch64_insn_hotpatch_safe(u32 old_insn, u32 new_insn);
>  int aarch64_insn_patch_text_nosync(void *addr, u32 insn);
>  int aarch64_insn_patch_text_sync(void *addrs[], u32 insns[], int cnt);
>  int aarch64_insn_patch_text(void *addrs[], u32 insns[], int cnt);
> +
> +bool aarch32_insn_is_wide_instruction(u32 insn);

Nitpick: too wide function name ;). Maybe aarch32_insn_is_wide().

Otherwise the patch looks fine.

Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>



More information about the linux-arm-kernel mailing list