[PATCH v2] ARM: BCM5301X: set customized AUXCTL
Florian Fainelli
f.fainelli at gmail.com
Mon Nov 3 15:39:28 PST 2014
On 11/03/2014 03:16 PM, Hauke Mehrtens wrote:
> On 11/03/2014 11:00 AM, Arnd Bergmann wrote:
>> On Saturday 01 November 2014 15:41:38 Hauke Mehrtens wrote:
>>> };
>>>
>>> DT_MACHINE_START(BCM5301X, "BCM5301X")
>>> - .l2c_aux_val = 0,
>>> + .l2c_aux_val = L310_AUX_CTRL_CACHE_REPLACE_RR |
>>> + L310_AUX_CTRL_DATA_PREFETCH |
>>> + L310_AUX_CTRL_INSTR_PREFETCH |
>>> + L310_AUX_CTRL_EARLY_BRESP,
>>
>> Please put these into the dts file instead if the boot loader fails
>> to set them correctly. We should not override them from source code
>> for new platforms any more.
> I checked again and I only need L310_AUX_CTRL_DATA_PREFETCH and
> L310_AUX_CTRL_INSTR_PREFETCH, the others get activate by the existing
> code. Should I make it possible to give l2c_aux_val through dt, or
> should I create some boolean options for L310_AUX_CTRL_DATA_PREFETCH
> and L310_AUX_CTRL_INSTR_PREFETCH?
Last we talked about these prefetch bits with Russell, I think we kind
of agreed that they could probably be enabled by default
There is already a large number of properties defined in
Documentation/devicetree/bindings/arm/l2cc.txt, I suppose that having
prefetch properties could work too.
--
Florian
More information about the linux-arm-kernel
mailing list