[PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default
Iyappan Subramanian
isubramanian at apm.com
Mon Nov 3 11:45:44 PST 2014
Hi Arnd,
On Thu, Oct 30, 2014 at 3:13 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 29 October 2014 17:56:19 Iyappan Subramanian wrote:
>> @@ -621,7 +621,7 @@
>> };
>> };
>>
>> - sgenet0: ethernet at 1f210000 {
>> + sgenet0: sgenet at 1f210000 {
>> compatible = "apm,xgene-enet";
>> status = "disabled";
>> reg = <0x0 0x1f210000 0x0 0x10000>,
>>
>
> This looks like you accidentally reverted a bug fix made earlier.
> Network devices should always have the name 'ethernet at ...'.
Thanks for the review. Since our firmware was patching the dtb, based
on the node-name, we thought by changing node-name, we can avoid the
patching and maintain backward compatibility.
Now we know that network devices should have 'ethernet at ...', we will
handle the backward compatibility in a different way and will post the
patch v2 shortly.
>
> Arnd
More information about the linux-arm-kernel
mailing list