[PATCH v2 0/4] Add support for pxa27x device-tree machine
Arnd Bergmann
arnd at arndb.de
Mon Nov 3 02:11:02 PST 2014
On Monday 03 November 2014 08:32:57 Robert Jarzmik wrote:
> Arnd Bergmann <arnd at arndb.de> writes:
>
> > On Thursday 30 October 2014 07:55:48 Robert Jarzmik wrote:
> > Whole series
> >
> > Acked-by: Arnd Bergmann <arnd at arndb.de>
> Thanks Arnd.
>
> Unfortunately my checkers caught a flaw in the non-device tree case :
> - pxa27x_dt_init_irq() is defined, even if unused
> - it calls pxa_dt_irq_init(), which is conditionaly defined on CONFIG_OF
> => breaks non DT builds
>
> So I'll have to enclose this function in a #if defined(CONFIG_OF), and respin
> patch 1.
Please make it use
if (IS_ENABLED(CONFIG_OF))
pxa_dt_irq_init(pxa27x_set_wake);
so we get the build-time coverage.
Arnd
More information about the linux-arm-kernel
mailing list