[PATCH 0/5] pinctrl: sunxi: Add A31 external interrupts support

Chen-Yu Tsai wens at csie.org
Wed May 28 05:14:52 PDT 2014


Hi,

On Wed, May 28, 2014 at 6:27 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> Hi everyone,
>
> This is an attempt at making the external interrupts on the A31 and
> the A23 working.
>
> The main difference with the previous code is that there's now several
> banks and several parent interrupts, instead of a single bank with a
> single parent interrupt in the older SoCs.
>
> Most of the diffstat is to register the new irq pin functions. The
> real code additions are those in the core pinctrl driver.
>
> Maxime
>
> Maxime Ripard (5):
>   pinctrl: sunxi: Remove irq_mask_ack and use irq_ack instead
>   pinctrl: sunxi: Add macro definition for pinctrl with more than one
>     interrupt
>   pinctrl: sunxi: Declare the number of interrupt banks in the
>     descriptor
>   pinctrl: sunxi: Declare the interrupt function for the A31
>   pinctrl: sunxi: Implement multiple interrupt banks support

The first 4 patches look good. The last one needs some work with the
sunxi_irq_*_reg helpers.


Thanks
ChenYu

>  drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c   |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sun5i-a10s.c  |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sun5i-a13.c   |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c   | 217 +++++++++++++++++++---------
>  drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c   |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c       |  77 ++++++----
>  drivers/pinctrl/sunxi/pinctrl-sunxi.h       |  21 ++-
>  8 files changed, 219 insertions(+), 101 deletions(-)
>
> --
> 1.9.3
>



More information about the linux-arm-kernel mailing list