[PATCH v3 03/14] ARM: KVM: handle 64bit values passed to mrcc or from mcrr instructions in BE case

Victor Kamensky victor.kamensky at linaro.org
Tue May 27 23:09:47 PDT 2014


On 26 May 2014 08:28, Christoffer Dall <christoffer.dall at linaro.org> wrote:
> On Tue, May 13, 2014 at 09:13:55AM -0700, Victor Kamensky wrote:
>> In some cases the mcrr and mrrc instructions in combination with the ldrd
>> and strd instructions need to deal with 64bit value in memory. The ldrd
>> and strd instructions already handle endianness within word (register)
>> boundaries but to get effect of the whole 64bit value represented correctly,
>> rr_lo_hi macro is introduced and is used to swap registers positions when
>> the mcrr and mrrc instructions are used. That has the effect of swapping
>> two words.
>
> So in this version you decided to keep the ordering of the TTBRX and
> TTBRX_high bits (high being most significant).  I assume this is because
> of the trapping of VM registers introduced by mark and to maintain
> access_vm_reg()?

Yes, that is correct.

> Any other changes since the last version?

No

> If none, then for the content of this patch:
>
> Reviewed-by: Christoffer Dall <christoffer.dall at linaro.org>

Thanks,
Victor



More information about the linux-arm-kernel mailing list