[PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV
myungjoo.ham at samsung.com
Sat May 24 05:40:31 PDT 2014
On Fri, May 23, 2014 at 1:52 PM, MyungJoo Ham <myungjoo.ham at samsung.com> wrote:
> On Thu, May 22, 2014 at 5:37 AM, Paul Bolle <pebolle at tiscali.nl> wrote:
>> Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig
>> symbol has never been added to the tree. Remove these checks, as they
>> always evaluate to false.
>> Signed-off-by: Paul Bolle <pebolle at tiscali.nl>
> Thanks for pointing this out.
> ASV was supposed to be merged, but it appears it failed or never attempted.
> I will merge with the next batch (this week).
Uh.. ASV itself affects the power efficiency; thus, I'd like to keep
it alive, but not as the current form.
For 3.16, I'll correct the name following your report. (not going for
Then, I'll let it merged into struct busfreq_data for later RCx.
>> 0) Untested.
>> 1) I do not really care much for this patch. Two years is not very long
>> for dead code to remain in the tree. There is, however, a trivial issue
>> that makes this patch stand out from the other patches in my current
>> sweep of the tree for Kconfig related problems.
>> See, here the use of an unknown Kconfig macro hides an obvious typo: it
>> should either be "exynos_result_of_asv" or "exynos4_result_of_asv", but
>> not both. Ie, this almost certainly wouldn't have compiled even if the
>> Kconfig symbol EXYNOS_ASV would have been part of the tree.
>> 2) So this makes me wonder whether there are any guidelines for using
>> Kconfig macros before the related Kconfig symbols are merged?
>> drivers/devfreq/Kconfig | 3 +--
>> drivers/devfreq/exynos/exynos4_bus.c | 13 -------------
>> 2 files changed, 1 insertion(+), 15 deletions(-)
MyungJoo Ham, Ph.D.
System S/W Lab, S/W Center, Samsung Electronics
More information about the linux-arm-kernel