[PATCH v3] clk: shmobile: Add R8A7740-specific clock support

[Laurent Pinchart]

Hi Geert,

On Wednesday 21 May 2014 17:50:35 Geert Uytterhoeven wrote:
> On Wed, May 21, 2014 at 5:41 PM, Laurent Pinchart wrote:
> >> +cpg_clocks: cpg_clocks at e6150000 {
> >> +        compatible = "renesas,r8a7740-cpg-clocks";
> >> +        reg = <0xe6150000 0x10000>;
> > 
> > This range covers the MSTP registers. Unlike other Renesas SoCs with CCF
> > support in mainline, the MSTP registers are in the middle of the CPG
> > address space here, which is quite problematic.
> 
> This is also the case for R-Car Gen2?!?
> 
>                 /* Special CPG clocks */
>                 cpg_clocks: cpg_clocks at e6150000 {
>                         compatible = "renesas,r8a7791-cpg-clocks",
>                                      "renesas,rcar-gen2-cpg-clocks";
>                         reg = <0 0xe6150000 0 0x1000>;
> 
>                 mstp0_clks: mstp0_clks at e6150130 {
>                         compatible = "renesas,r8a7791-mstp-clocks",
> "renesas,cpg-mstp-clocks";
>                         reg = <0 0xe6150130 0 4>, <0 0xe6150030 0 4>;

Indeed :-/ It looks like we're just lucky that of_iomap() doesn't request the 
memory resource.

Do you think it would make sense to move the MSTP nodes inside the CPG node to 
better describe the hardware, and avoid future breakages if of_iomap() starts 
calling request_resource() tomorrow ?

> Or perhaps I am misunderstanding what you mean?

-- 
Regards,

Laurent Pinchart