[PATCH v2] ARM: realview: basic device tree implementation

Linus Walleij linus.walleij at linaro.org
Thu May 22 06:30:39 PDT 2014

On Thu, May 22, 2014 at 3:17 PM, Rob Herring <robh at kernel.org> wrote:
> On Thu, May 8, 2014 at 5:08 PM, Linus Walleij <linus.walleij at linaro.org> wrote:

>> +       model = "ARM RealView PB1176 with device tree";
> Isn't "with device tree" redundant?

Nuked it.

>> +static struct map_desc realview_dt_io_desc[] __initdata = {
>> +       {
>> +               /* FIXME: static map needed for LED driver */
> Don't you have patches to fix this? I need them for Versatile
> conversion as well.

Done away with. The legacy driver was moved to drivers/leds/leds-versatile.c
and I then contemplated adding DT support to it but it was a *bad*

Instead I have created drivers/leds/leds-syscon.c that can handle
any LEDs in a syscon. Will post in next iteration as soon as
I get the drivers/soc dependency in place.

>> +       if (of_machine_is_compatible("arm,realview-eb"))
>> +               /*
>> +                * 1MB (128KB/way), 8-way associativity,
> These should go into DT properties. Cache attributes are already
> defined in ePAPR.

Yes, the dependencies to do this with DT is floating around somewhere
in the ARM tree or Russells tree I think, maybe I cannot do this until
the next kernel cycle.

>> +                * evmon/parity/share enabled
> These can probably be unconditionally enabled except for parity which
> could be a DT property.

I'll wait and see what I need to add really.

>> +       parent = soc_device_to_device(soc_dev);
> We really need to standardize this soc device stuff so that platforms
> always have a parent soc device or not.

Arnds position is that the entire platform/board should not be
a "soc device" and that seems correct since the board is no SoC.

So I will spin this off into a SoC driver and push under
drivers/soc and bind to the SoC node in the device tree.

Linus Walleij

More information about the linux-arm-kernel mailing list