[PATCH] clk: divider: Fix table round up function

Maxime Coquelin maxime.coquelin at st.com
Wed May 21 05:52:16 PDT 2014

Hi Mike,

On 05/15/2014 03:28 PM, Fabio Estevam wrote:
> Hi Mike,
> On Wed, May 7, 2014 at 1:48 PM, Maxime COQUELIN <maxime.coquelin at st.com> wrote:
>> Commit 1d9fe6b97 ("clk: divider: Fix best div calculation for power-of-two and
>> table dividers") introduces a regression in its _table_round_up function.
>> When the divider passed to this function is greater than the max divider
>> available in the table, this function returns table's max divider.
>> Problem is that it causes an infinite loop in clk_divider_bestdiv() because
>> _next_div() will never return a value greater than maxdiv.
>> Instead of returning table's max divider, this patch returns INT_MAX.
>> Reported-by: Fabio Estevam <festevam at gmail.com>
>> Reported-by: Shawn Guo <shawn.guo at freescale.com>
>> Tested-by: Fabio Estevam <festevam at gmail.com>
>> Cc: Mike Turquette <mike.turquette at linaro.org>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin at st.com>
> Any comments on this one? It does fix a regression.

This patch is important as it fixes a regression, could you review it 


More information about the linux-arm-kernel mailing list