[PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier
tony at atomide.com
Tue May 20 08:07:49 PDT 2014
* Lee Jones <lee.jones at linaro.org> [140520 08:02]:
> On Tue, 13 May 2014, Tony Lindgren wrote:
> > Looks like we can still hit the issue of wrong load order of
> > twl4030 configuration. If we have a sleep configuration loaded,
> > and do a warm reset, the device can hang while initializing the
> > wakeup12 sequence. We do have a warning message about wrong order
> > of twl4030 configuration, but in this case it does not help as
> > the sleep configuration was loaded during the previous boot and
> > the state of twl4030 is maintained throughout the warm reset.
> > Fix the issue by clearing any existing sleep configuration
> > before we load the warm reset configuration.
> > Cc: Peter Ujfalusi <peter.ujfalusi at ti.com>
> > Signed-off-by: Tony Lindgren <tony at atomide.com>
> > ---
> > drivers/mfd/twl4030-power.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> Can't vouch for the semantics of the patch, but the code looks good.
> Acked-by: Lee Jones <lee.jones at linaro.org>
> Can I just apply this, or would you like Peter to review it first?
As far as I'm concerned you can go ahead an apply, it's been
floating on the list for a while and Peter is probably busy
with other things.
More information about the linux-arm-kernel