[PATCH 1/2] dmaengine: s3c24xx-dma: Process whole SG chain

Heiko Stübner heiko at sntech.de
Sun May 18 15:50:43 PDT 2014


Am Sonntag, 18. Mai 2014, 23:42:58 schrieb Vasily Khoruzhick:
> Due to redundant 'break' in a loop the driver processed only the first
> chunk.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>

Looks like a forgotten remnant of the time when the driver only supported sg-
lists with one element, thanks for catching this.

Reviewed-by: Heiko Stuebner <heiko at sntech.de>

> ---
>  drivers/dma/s3c24xx-dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 4eddedb..2167608 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -961,7 +961,6 @@ static struct dma_async_tx_descriptor
> *s3c24xx_dma_prep_slave_sg( dsg->src_addr = slave_addr;
>  			dsg->dst_addr = sg_dma_address(sg);
>  		}
> -		break;
>  	}
> 
>  	return vchan_tx_prep(&s3cchan->vc, &txd->vd, flags);




More information about the linux-arm-kernel mailing list