[PATCH v6 03/15] irq: gic: support hip04 gic

[Christoffer Dall]

On 15 May 2014 13:13, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 15 May 2014 13:08:17 Christoffer Dall wrote:
>> On 15 May 2014 12:14, Arnd Bergmann <arnd at arndb.de> wrote:
>> > On Thursday 15 May 2014 10:34:35 Marc Zyngier wrote:
>> >> > +static inline bool gic_is_standard(struct gic_chip_data *gic)
>> >>
>> >> Please loose all of the inlines. The compiler can do this by itself.
>> >>
>> >> > +{
>> >> > +       return (gic->nr_cpu_if == 8);
>> >> > +}
>> >> > +
>> >
>> > I think it's actually the common style to spell out the 'inline'
>> > for trivial helpers like this. The compiler doesn't need it, but
>> > it also doesn't hurt and most people write it.
>> >
>> Only in header files, no?
>>
>> I've been chastised previously for putting this in .c files.
>
> It's crazy to make it a hard rule for C files one way or the other,
> given that the compiler doesn't care.
>
> I normally spell out the the inline part in my code because I find
> that clearer to read.
>
if that's the general consensus, I'll stop caring about it then.

-Christoffer