[PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree

Viresh Kumar viresh.kumar at linaro.org
Wed May 14 06:54:54 PDT 2014


On 14 May 2014 19:16, Thomas Abraham <ta.omasab at gmail.com> wrote:
> On Wed, May 14, 2014 at 9:10 AM, Viresh Kumar <viresh.kumar at linaro.org> wrote:

>> Why is this present outside of above if {} ? as boost_freqs is guaranteed to
>> be NULL without that.
>
> Just to reduce indentation by one tab. No technical reasons. The code
> had to wrap at 80 column was becoming unreadable.

That's bad :), you have added an extra comparison just for that :(
Instead kill the below indentation by doing a "goto out" with a ! of
below expression:

>> +       if (of_find_property(dev->of_node, "boost-frequency", &len)) {



More information about the linux-arm-kernel mailing list