[PATCH] input: pxa27x-keypad: bug fix of getting scan code

Dmitry Torokhov dmitry.torokhov at gmail.com
Tue May 13 23:12:05 PDT 2014


On Mon, Jan 27, 2014 at 12:41:37PM +0800, Chao Xie wrote:
> From: Chao Xie <chao.xie at marvell.com>
> 
> The rows of pxa27x-keypad used by each boards are not fixed.
> So in the driver, it will get the rows from DT and register
> the keymap as:
> matrix_keypad_build_keymap(keymap_data, NULL,
>                            pdata->matrix_key_rows,
>                            pdata->matrix_key_cols,
>                            keypad->keycodes, input_dev);
> 
> But the scan code is gotten as
> MATRIX_SCAN_CODE(row, col, MATRIX_ROW_SHIFT);
> It is not correct. Fix it as
> MATRIX_SCAN_CODE(row, col, keypad->row_shift);
> 
> row_shift is calculated from pdata->matrix_key_rows.
> 
> Signed-off-by: Chao Xie <chao.xie at marvell.com>

Applied with minor edits, thank you.

-- 
Dmitry



More information about the linux-arm-kernel mailing list