[PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG
gregkh at linuxfoundation.org
Tue May 13 04:11:44 PDT 2014
On Tue, May 13, 2014 at 10:19:27AM +0800, Peter Chen wrote:
> the user should only select it when the board supports HNP and SRP,
> it should NOT be selected if the board only supports dual-role
> switch through ID pin.
> There is a discussion for it:
> Signed-off-by: Peter Chen <peter.chen at freescale.com>
> drivers/usb/core/Kconfig | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index cb8e991..158048b 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -54,13 +54,15 @@ config USB_OTG
> default n
> The most notable feature of USB OTG is support for a
> - "Dual-Role" device, which can act as either a device
> - or a host. The initial role is decided by the type of
> - plug inserted and can be changed later when two dual
> - role devices talk to each other.
> + otg device, which can act as either a device or a host.
> + The initial role is decided by the type of plug inserted
> + and can be changed using HNP (Host Negotiation Protocol)
> + later when two otg devices talk to each other.
> Select this only if your board has Mini-AB/Micro-AB
> - connector.
> + connector and supports HNP and SRP (Session Request Protocol).
> + If the board only supports dual-role switch through ID
> + pin, this configuration should not be selected.
That's really lame. What happened to our "all modconfig should work"
goal? Why can't you dynamically detect that this is not a config that
works and handle it?
And this is just the OTG "core", not any specific hardware, so why
should it matter?
More information about the linux-arm-kernel