[PATCH 3/7] clk: sunxi: avoid double DT matching
Rob Herring
robherring2 at gmail.com
Mon May 12 17:29:49 PDT 2014
From: Rob Herring <robh at kernel.org>
Use for_each_matching_node_and_match instead of for_each_matching_node plus
of_match_node to avoid searching the DT twice for each node.
The sunxi DT scanning code should really be re-worked rather than have
its own private matching infrastructure. It is working around needing a
function pointer and a data pointer for each compatible match.
Signed-off-by: Rob Herring <robh at kernel.org>
Cc: "Emilio López" <emilio at elopez.com.ar>
Cc: Mike Turquette <mturquette at linaro.org>
Cc: Maxime Ripard <maxime.ripard at free-electrons.com>
---
drivers/clk/sunxi/clk-sunxi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index bd7dc73..7977106 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -1278,8 +1278,7 @@ static void __init of_sunxi_table_clock_setup(const struct of_device_id *clk_mat
const struct of_device_id *match;
void (*setup_function)(struct device_node *, const void *) = function;
- for_each_matching_node(np, clk_match) {
- match = of_match_node(clk_match, np);
+ for_each_matching_node_and_match(np, clk_match, match) {
data = match->data;
setup_function(np, data);
}
--
1.9.1
More information about the linux-arm-kernel
mailing list