[PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()

Dirk Behme dirk.behme at de.bosch.com
Sun May 11 22:45:56 PDT 2014

On 12.05.2014 05:40, Huang Shijie wrote:
> 于 2014年05月09日 23:19, dean_jenkins at mentor.com 写道:
>> Use imx_start_tx() just to enable the TX interrupt. It's the job of the
>> TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer
>> is empty, the TX interrupt should be executed as soon as the start_tx()
>> enables the interrupt, so there is no reason for the extra
>> imx_transmit_buffer() call, here. Remove it.
> I don't know why this patch needed?
> What problem this patch fix or improve?

As stated in the commit message, the call of imx_transmit_buffer() isn't 
needed there, so it can be removed. I.e. remove unneeded code.

In the end, this cleans up the possible locking path, so that in the 
third patch the locking issue can be easily fixed.

Best regards


More information about the linux-arm-kernel mailing list