Re: [PATCH 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap

[Alexander Shiyan]

Sat, 10 May 2014 15:26:58 +0530 от Vivek Gautam <gautam.vivek at samsung.com>:
> Using devm_ioremap_resource() API should actually be preferred over
> devm_ioremap(), since the former request the mem region first and then
> gives back the ioremap'ed memory pointer.
> devm_ioremap_resource() calls request_mem_region(), therby preventing
> other drivers to make any overlapping call to the same region.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>
> ---
>  drivers/usb/host/ehci-exynos.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 7f425ac..bccb6f1 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -135,9 +135,8 @@ skip_phy:
>  
>  	hcd->rsrc_start = res->start;
>  	hcd->rsrc_len = resource_size(res);
> -	hcd->regs = devm_ioremap(&pdev->dev, res->start, hcd->rsrc_len);
> +	hcd->regs = devm_ioremap_resource(&pdev->dev, res);
>  	if (!hcd->regs) {
> -		dev_err(&pdev->dev, "Failed to remap I/O memory\n");
>  		err = -ENOMEM;
>  		goto fail_io;
>  	}

You should check this as:

if (IS_ERR(hcd->regs)) {
err = PTR_ERR(hcd->regs);
...

Same in other patches in this series.

---