[PATCH 1/5] serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()

dean_jenkins at mentor.com dean_jenkins at mentor.com
Fri May 9 08:19:44 PDT 2014

From: Dirk Behme <dirk.behme at de.bosch.com>

Use imx_start_tx() just to enable the TX interrupt. It's the job of the
TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer
is empty, the TX interrupt should be executed as soon as the start_tx()
enables the interrupt, so there is no reason for the extra
imx_transmit_buffer() call, here. Remove it.

Signed-off-by: Dirk Behme <dirk.behme at de.bosch.com>
Signed-off-by: Andy Lowe <andy_lowe at mentor.com>
 drivers/tty/serial/imx.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 3b6c1a2..7b813b3 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -600,9 +600,6 @@ static void imx_start_tx(struct uart_port *port)
-	if (readl(sport->port.membase + uts_reg(sport)) & UTS_TXEMPTY)
-		imx_transmit_buffer(sport);
 static irqreturn_t imx_rtsint(int irq, void *dev_id)

More information about the linux-arm-kernel mailing list