Re: [PATCH v2] ARM: dts: imx6: add new board RIoTboard

[Alexander Shiyan]

Thu, 08 May 2014 20:27:55 +0100 от Iain Paton <ipaton0 at gmail.com>:
> On 08/05/14 18:32, Alexander Shiyan wrote:
> > Thu, 08 May 2014 18:12:02 +0100 от Iain Paton <ipaton0 at gmail.com>:
> >> +&aips2 {
> >> +        i2c4: i2c at 021f8000 {
> >> +                #address-cells = <1>;
> >> +                #size-cells = <0>;
> >> +                compatible = "fsl,imx1-i2c";
> > 
> > Are you sure about use "fsl,imx1-i2c" instead of  "fsl,imx21-i2c"?
> > In any case you should add "fsl-imx6dl-i2c" as first compatible string.
> > The rest looks good.
> 
> Sure?  No.  However that's what currently exists in imx6dl.dtsi for i2c4.
> 
> looking at the other i2c interfaces in imx6qdl.dtsi, they're using
> fsl,imx6q-i2c as the first compatible string. So I think I should use
> either fsl,imx6dl-i2c or fsl,imx6q-i2c. 
> What's the difference between that and your suggested fsl-imx6dl-i2c?
> If we assume can assume the i2c4 block is functionally identical to
> i2c[123] then shouldn't I use an identical compatible string?

Yes. This is just my typo. If all I2C-interfaces is identical in the datasheet,
the same compatible string (fsl,imx6q-i2c) should be used.

---