[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

Rahul Sharma rahul.sharma at samsung.com
Thu May 8 02:15:08 PDT 2014


On 8 May 2014 12:50, Jingoo Han <jg1.han at samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma at samsung.com>
>>
>> Enable fimd node for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma at samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..796954c 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,10 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     fimd at 14400000 {
>> +             status = "okay";
>
> (+cc Sachin Kamat, Tomasz Figa)
>
> For readability, how about moving 'status' to the last entry of
> the node? The same comment applies to other patches, too.
>

I just followed the nodes in rest of the file for peach and snow. This
looks consistent to me. But let me know if you want me to change
this.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>> +             samsung,invert-vclk;
>> +     };
>> +
>>  };
>> --
>> 1.7.9.5
>
>



More information about the linux-arm-kernel mailing list