[PATCH] clk: divider: Fix table round up function

Maxime COQUELIN maxime.coquelin at st.com
Wed May 7 09:48:52 PDT 2014

Commit 1d9fe6b97 ("clk: divider: Fix best div calculation for power-of-two and
table dividers") introduces a regression in its _table_round_up function.

When the divider passed to this function is greater than the max divider
available in the table, this function returns table's max divider.
Problem is that it causes an infinite loop in clk_divider_bestdiv() because
_next_div() will never return a value greater than maxdiv.

Instead of returning table's max divider, this patch returns INT_MAX.

Reported-by: Fabio Estevam <festevam at gmail.com>
Reported-by: Shawn Guo <shawn.guo at freescale.com>
Tested-by: Fabio Estevam <festevam at gmail.com>
Cc: Mike Turquette <mike.turquette at linaro.org>
Signed-off-by: Maxime Coquelin <maxime.coquelin at st.com>
 drivers/clk/clk-divider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
index b3c8396..cf9114a 100644
--- a/drivers/clk/clk-divider.c
+++ b/drivers/clk/clk-divider.c
@@ -158,7 +158,7 @@ static bool _is_valid_div(struct clk_divider *divider, unsigned int div)
 static int _round_up_table(const struct clk_div_table *table, int div)
 	const struct clk_div_table *clkt;
-	int up = _get_table_maxdiv(table);
+	int up = INT_MAX;
 	for (clkt = table; clkt->div; clkt++) {
 		if (clkt->div == div)

More information about the linux-arm-kernel mailing list