[GIT PULL] Versatile LEDs conversion

Arnd Bergmann arnd at arndb.de
Tue May 6 05:58:22 PDT 2014

On Monday 05 May 2014, Olof Johansson wrote:
> On Fri, Mar 28, 2014 at 11:02:57AM +0100, Linus Walleij wrote:
> > Hi ARM SoC folks,
> > 
> > here is a Versatile LEDs patch stack, it has been finished for a while,
> > but delayed waiting for an ACK from the LEDs subsystem maintainer
> > which arrived today. (My bad for not hunting it more actively.)
> > 
> > I pretty sure the patches are safe and they need some rotation in linux-next,
> > but I understand if you want to wait until after v3.15-rc1 before pulling this
> > in. (I'll nag you later in that case.)
> Merged into next/cleanup.

I got a build error today, since LEDS_VERSATILE can be built-in while LEDS_CLASS
is a module:

drivers/built-in.o: In function `versatile_leds_probe':
:(.text+0x155020): undefined reference to `led_classdev_register'

I suggest we turn this option into 'tristate' so that the dependency
tracking works correctly.

Signed-off-by: Arnd Bergmann <arnd at arndb.de>

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 1e81d7a..6784c17 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -477,7 +477,7 @@ config LEDS_BLINKM
 	  through I2C. Say Y to enable support for the BlinkM LED.
-	bool "LED support for the ARM Versatile and RealView"
+	tristate "LED support for the ARM Versatile and RealView"
 	depends on LEDS_CLASS

More information about the linux-arm-kernel mailing list