Re: [PATCH 1/2] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: Add CAN support

[Alexander Shiyan]

Mon,  5 May 2014 19:00:47 -0300 от Fabio Estevam <festevam at gmail.com>:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Add support for CAN based on a MPC2515 connected to ECSPI1.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
> Eric/Denis,
> 
> I don't have the hardware to test it. Please give it a test.
> 
>  .../boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts  | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> index 8b1098e..f0067e9 100644
> --- a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> +++ b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> @@ -86,6 +86,24 @@
>  	status = "okay";
>  };
>  
> +&ecspi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi1>;
> +	fsl,spi-num-chipselects = <1>;
> +	cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;

Really CS High for this?
I think this is wrong.

> +	status = "okay";
> +
> +	can0: can at 0 {
> +		compatible = "microchip,mcp2515";
> +		reg = <0>;
> +		clocks = <&clks IMX5_CLK_OSC>;
> +		spi-max-frequency = <1000000>;
> +		spi-cs-high;

Ditto.

> +		interrupt-parent = <&gpio1>;
> +		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> +	};
> +};
> +
>  &i2c1 {
>  	tlv320aic23: codec at 1a {
>  		compatible = "ti,tlv320aic23";
> @@ -104,6 +122,22 @@
>  			>;
>  		};
>  
> +		pinctrl_ecspi1: ecspi1grp {
> +			fsl,pins = <
> +				MX51_PAD_CSPI1_MISO__ECSPI1_MISO	0x185
> +				MX51_PAD_CSPI1_MOSI__ECSPI1_MOSI	0x185
> +				MX51_PAD_CSPI1_SCLK__ECSPI1_SCLK	0x185
> +				MX51_PAD_CSPI1_SS0__GPIO4_24		0x80000000 	/* CS0 */

...
> +				MX51_PAD_CSI2_PIXCLK__GPIO4_15		0x80000000	/* nReset */
> +				MX51_PAD_GPIO1_1__GPIO1_1		0x80000000	/* IRQ */
> +				MX51_PAD_GPIO1_4__GPIO1_4		0x80000000	/* Control signals */
> +				MX51_PAD_GPIO1_6__GPIO1_6		0x80000000
> +				MX51_PAD_GPIO1_7__GPIO1_7		0x80000000
> +				MX51_PAD_GPIO1_8__GPIO1_8		0x80000000
> +				MX51_PAD_GPIO1_9__GPIO1_9		0x80000000

Unknown GPIOs.

---