[PATCH v6 02/12] ARM/ARM64: KVM: Add common header for PSCI related defines

Ashwin Chaugule ashwin.chaugule at linaro.org
Mon Mar 31 14:18:20 EDT 2014


Hello,

On 31 March 2014 14:07, Christoffer Dall <christoffer.dall at linaro.org> wrote:
> On Mon, Mar 31, 2014 at 04:16:03PM +0530, Anup Patel wrote:
>> We need a common place to share PSCI related defines among ARM kernel,
>> ARM64 kernel, KVM ARM/ARM64 PSCI emulation, and user space.
>>
>> We introduce uapi/linux/psci.h for this purpose. This newly added
>> header will be first used by KVM ARM/ARM64 in-kernel PSCI emulation
>> and user space (i.e. QEMU or KVMTOOL).
>>
>> Signed-off-by: Anup Patel <anup.patel at linaro.org>
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar at linaro.org>
>> ---
>>  include/uapi/linux/Kbuild |    1 +
>>  include/uapi/linux/psci.h |   55 +++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 56 insertions(+)
>>  create mode 100644 include/uapi/linux/psci.h
>>
>
> You should coordinate with Ashwin's work so you don't step on each
> other's definitions and one patch set should depend on the other one.

So, apart from some extra #defines we mostly differ on style. Whats
the general recommendation here?
Mine looks simpler [1] ;)


Cheers,
Ashwin

[1] http://www.spinics.net/lists/arm-kernel/msg319090.html



More information about the linux-arm-kernel mailing list