[linux-sunxi] Re: [PATCH v3 08/10] ARM: sun7i/sun4i: dt: Add AXP209 support to various boards

[Carlo Caione]

On Fri, Mar 28, 2014 at 4:12 AM, Chen-Yu Tsai <wens at csie.org> wrote:
>> diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts
>> index fa746aea..cf18c4d 100644
>> --- a/arch/arm/boot/dts/sun4i-a10-a1000.dts
>> +++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts
>> @@ -88,6 +88,19 @@
>>                         pinctrl-names = "default";
>>                         pinctrl-0 = <&i2c0_pins_a>;
>>                         status = "okay";
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +
>> +                       axp: axp20x at 34 {
>
> Hi,
>
> Sorry for spotting this just now. I suggest you change it to
>
>                           axp209: pmic at 34 {
>
> or
>
>                           axp209_pmic at 34 {
>
> to match the ePAPR policy that node names should be generic and
> describe functionality. The latter is what some DTs use.

Right. Thanks for reviewing this.

> Same for all the other files.
>
> Thanks for working on this!

Thank you,

-- 
Carlo Caione