[PATCH] ARM: rockchip: rk3188: enable pull-ups on UART inputs
Max Schwarz
max.schwarz at online.de
Sat Mar 22 19:03:22 EDT 2014
Hi Heiko,
> ok, but as we change the default behaviour of the pin - and as we discussed
> above rightfully so, the commit message should reflect this and not describe
> a Radxa-Rock specific change. So would you be ok with something like:
>
> ---------- 8< --------------------
> Subject: [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART RX pins
>
> The default behaviour of the uart-rx pins on the rk3188 is to be pulled up
> and a lot of designs use diodes to even prevent them from being raised from
> the outside.
>
> Therefore change the rx-pin settings accordingly.
>
> This also fixes a uart receive problem on mass production Radxa Rock boards.
> ---------- 8< --------------------
Yes, that sounds good to me. Thanks!
Cheers,
Max
More information about the linux-arm-kernel
mailing list