[linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

Mark Brown broonie at kernel.org
Sat Mar 22 13:33:13 EDT 2014


On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote:
> On Tue, Mar 18, 2014 at 03:59:19PM +0000, Lee Jones wrote:

> > > +	of_id = of_match_device(axp20x_of_match, &i2c->dev);
> > > +	if (!of_id) {
> > > +		dev_err(&i2c->dev, "Unable to setup AXP20X data\n");
> > > +		return -ENODEV;
> > > +	}
> > > +	axp20x->variant = (int) of_id->data;

> > No need to cast from void *.

> My compiler says otherwise :)

Are you sure your compiler isn't correctly telling you not to cast away
const?  If the compiler is complaining about a cast on void then it's
spotted a definite bug.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140322/634fefa6/attachment.sig>


More information about the linux-arm-kernel mailing list