[PATCH v2 5/8] regulator: AXP20x: Add support for regulators subsystem
broonie at kernel.org
Mon Mar 17 13:33:07 EDT 2014
On Sat, Mar 15, 2014 at 04:43:42PM +0100, Carlo Caione wrote:
> AXP202 and AXP209 come with two synchronous step-down DC-DCs and five
> LDOs. This patch introduces basic support for those regulators.
This is mostly fine apart from the things Krzysztof mentioned and...
> +static int axp20x_set_dcdc_freq(struct platform_device *pdev, u32 dcdcfreq)
> + struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> + if (dcdcfreq < 750)
> + dcdcfreq = 750;
> + if (dcdcfreq > 1875)
> + dcdcfreq = 1875;
I'd expect at least a warning on out of spec values being specified
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the linux-arm-kernel