[PATCH v5 2/3] ARM: dts: add dts files for exynos5260 SoC

[Tomasz Figa]

Hi,

On 12.03.2014 16:16, Rahul Sharma wrote:
> The patch adds the dts files for exynos5260.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey at samsung.com>
> Signed-off-by: Rahul Sharma <rahul.sharma at samsung.com>
> Signed-off-by: Arun Kumar K <arun.kk at samsung.com>
> Reviewed-by: Tomasz Figa <t.figa at samsung.com>
> ---
>   arch/arm/boot/dts/exynos5260-pinctrl.dtsi |  574 +++++++++++++++++++++++++++++
>   arch/arm/boot/dts/exynos5260.dtsi         |  400 ++++++++++++++++++++
>   2 files changed, 974 insertions(+)
>   create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi
>   create mode 100644 arch/arm/boot/dts/exynos5260.dtsi
>

[snip]


> +		mmc_0: mmc0 at 12140000 {

Node names should specify type of the device, so unit-specific IDs 
should be avoided. Please simply use mmc at 12140000. The same comment for 
remaining MMC nodes below.

Best regards,
Tomasz